Accept decimal strings in Intl.NumberFormat #57595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Uncommitted Bug
felixfbecker
force-pushed
the
intl-numberformat-v3
branch
from
164b246 to
7d5a85a
Compare
|
👍 (this is the relevant feature in the spec – strings are now converted to mathematical values, rather than coerced to numbers as in previous versions) FYI, the ECMA-402 v10 NumberFormat definitions were moved to |
|
Rebased. The new structure is nice! |
felixfbecker
force-pushed
the
intl-numberformat-v3
branch
from
7d5a85a to
97ff57e
Compare
|
This makes sense to me. I'll bring the issue up at a design meeting. |
felixfbecker
force-pushed
the
intl-numberformat-v3
branch
from
933fc24 to
a8c6947
Compare
|
We agreed that this makes sense. @felixfbecker would you mind bringing the PR up to date with main? |
sandersn
approved these changes
Apr 5, 2024
felixfbecker
force-pushed
the
intl-numberformat-v3
branch
from
a8c6947 to
bd132ea
Compare
|
@sandersn Awesome, I rebased onto |
simonrevill
pushed a commit
to simonrevill/tdd-shopping-cart
that referenced
this pull request
Apr 13, 2024
…g. Format method takes a string in the spec and will be updated by TypeScipt team soon. See microsoft/TypeScript#57595
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52124
Note: This is not a coercion like in other JS APIs that also "accept" strings by coercing them, it is specifically designed to handle arbitrary-length decimals without precision loss. This was added as an explicit feature in Intl.NumberFormat v3 (which is why I added it to
es2023.intl, which also housesformatRange(), which also got added in v3): https://github.com/tc39/proposal-intl-numberformat-v3#interpret-strings-as-decimals-ecma-402-334The format matches what
${number}accepts (plusInfinity):Spec link: https://tc39.es/ecma402/#sec-runtime-semantics-stringintlmv
It is very common to represent monetary numbers as strings in JSON APIs to avoid any precision loss and those can currently not be passed to the
Intl.NumberFormatAPI without castingas any. The resulting type errors currently misleads developers into usingparseFloat()to make the type error go away, which causes precision loss.It is supported by all browsers: https://caniuse.com/mdn-javascript_builtins_intl_numberformat_format_number_parameter-string_decimal